Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] updating docs with new license management flow and UX #864

Merged
merged 12 commits into from
Nov 16, 2023

Conversation

SimonWallner
Copy link
Contributor

@SimonWallner SimonWallner commented Oct 16, 2023

  • reflecting the upcoming changes in license and user management.
  • update most references to API_KEY to auth token
  • update most references to 'API keys' in ci context to 'CI key'
  • updated links into web app.

Merge when v3 is released!

don't merge before rolling out changes in front-end https://github.com/localstack/localstack-web/pull/1001

Todo

  • add missing screenshots, update screenshots where needed
  • check all links into the platform and update to new paths

@github-actions
Copy link

github-actions bot commented Oct 16, 2023

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-864.surge.sh 🎊

@SimonWallner SimonWallner marked this pull request as ready for review October 17, 2023 08:05
@SimonWallner SimonWallner changed the title DO NOT MERGE! updating docs with new license management flow and UX [v3] updating docs with new license management flow and UX Nov 15, 2023
Copy link
Member

@HarshCasper HarshCasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments:

  • The terminology is a bit unclear. Is it Auth Token or auth token? I guess we should go with the former consistently.
  • Rather than deleting the pages (which might trouble other users), let's put up a deprecation notice for the time being.
  • The docs are unclear about the path for API keys. Have they been deprecated? What's the timeline wherein they still work? And more questions.

content/en/getting-started/auth-token.md Outdated Show resolved Hide resolved
content/en/getting-started/auth-token.md Outdated Show resolved Hide resolved
@@ -0,0 +1,73 @@
---
title: "Managing Users and Licenses"
tags: ["LocalStack Pro", "Accounts"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the tags. Please add a linkTitle here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what should the linkTitle then be?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as title

content/en/user-guide/web-application/workspaces/index.md Outdated Show resolved Hide resolved
content/en/user-guide/ci/circle-ci/index.md Outdated Show resolved Hide resolved
@dominikschubert dominikschubert added this to the 3.0 milestone Nov 16, 2023
@HarshCasper HarshCasper force-pushed the licensem-management-10-2023 branch from af3fb03 to a0b18f0 Compare November 16, 2023 13:08
@HarshCasper HarshCasper merged commit e72c11c into main Nov 16, 2023
3 checks passed
@HarshCasper HarshCasper deleted the licensem-management-10-2023 branch November 16, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants