Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework the aws cli docs #863

Merged
merged 2 commits into from
Oct 16, 2023
Merged

rework the aws cli docs #863

merged 2 commits into from
Oct 16, 2023

Conversation

HarshCasper
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 16, 2023

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-863.surge.sh 🎊

Copy link
Member

@whummer whummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos @HarshCasper for another round of docs refactoring and unification! 🚀 LGTM overall, just two minor comments/suggestions..

[profile localstack]
region=us-east-1
output=json
endpoint_url = http://localhost:4566
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

content/en/user-guide/integrations/aws-cli/index.md Outdated Show resolved Hide resolved
@HarshCasper
Copy link
Member Author

After a discussion with @MarcelStranak, we will discuss refactoring of the AWS CLI v2 docs next week. I will merge this PR to give way to some new docs where the AWS profile needs to be mentioned.

@HarshCasper HarshCasper merged commit 728ca75 into main Oct 16, 2023
3 checks passed
@HarshCasper HarshCasper deleted the aws-cli-rework branch October 16, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants