-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split EKS commands and outputs for better copy and paste #841
Conversation
🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-841.surge.sh 🎊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great that you are changing the docs right when coming across issues!
For some of the changes in the PR it might make sense to use the new feature @webdev51 implemented: #804 (comment)
Wit that you can disable the copying for certain sections within the command, instead of separating command and output all the time (which sometimes makes sense, but sometimes disrupts the flow).
Thanks @alexrashed for the suggestion. I definitely prefer the output as rendered, however the copied command contains a newline at the end. An alternative is to do something like {{< command >}}
$ pwd<disable-copy>
/
</disable-copy>
{{< / command >}} which is a little ugly, but in general I prefer to not break up the reading flow as you say. |
Ah, interesting. A newline at the end really doesn't seem to be too nice when copy-pasting the commands. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 💯
Motivation
When starting an EKS cluster, I was copying the commands from the docs but the output was copied along with the commands.
Changes