Add build script for Lambda functions #1595
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1595.surge.sh 🎊 |
joe4dev
reviewed
Dec 14, 2024
| --role arn:aws:iam::000000000000:role/lambda-role \ | ||
| --environment Variables="{STAGE=local}" | ||
| --function-name presign \ | ||
| --runtime python3.9 \ |
There was a problem hiding this comment.
minor suggestion: Would it make sense to upgrade to python3.12 because 3.9 might get deprecated next year (it's the latest non-deprecation Python version) https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html
Thank you @tinyg210 for tackling the missing build instructions, that's indeed a common issue 👍
remotesynth
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build part for the Lambda functions was missing from the step-by-step instructions & from the repo. Users were a bit confused about how to proceed. This should make it clear