Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: multi account fix and include one case with non-default account ID in CI #75

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

WIP: multi account fix and include one case with non-default account ID in CI #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f2c852
include multiaccount in workflow
dominikschubert Oct 18, 2022
9308204
use env if available for credentials
dominikschubert Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/integrations.python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ on:
description: Upstream aws-cdk version to use in tests
required: false
env:
AWS_ACCESS_KEY_ID: test
AWS_SECRET_ACCESS_KEY: test

jobs:
Expand All @@ -23,11 +22,13 @@ jobs:
strategy:
matrix:
include:
- { language: python, node-version: '16.x', python-version: '3.10', region: us-east-1}
- { language: python, node-version: '16.x', python-version: '3.9', region: us-east-1}
- { language: python, node-version: '16.x', python-version: '3.8', region: us-east-1}
- { language: python, node-version: '16.x', python-version: '3.10', region: us-east-1, access-key-id: '000000000001'}
- { language: python, node-version: '16.x', python-version: '3.10', region: us-east-1, access-key-id: 'test'}
- { language: python, node-version: '16.x', python-version: '3.9', region: us-east-1, access-key-id: 'test'}
- { language: python, node-version: '16.x', python-version: '3.8', region: us-east-1, access-key-id: 'test'}

env:
AWS_ACCESS_KEY_ID: ${{ matrix.access-key-id }}
AWS_REGION: ${{ matrix.region }}
AWS_DEFAULT_REGION: ${{ matrix.region }}

Expand Down
4 changes: 2 additions & 2 deletions bin/cdklocal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ const setSdkOptions = (options, setHttpOptions) => {
}
options.endpoint = getLocalEndpoint();
options.s3ForcePathStyle = true;
options.accessKeyId = "test";
options.secretAccessKey = "test";
options.accessKeyId = process.env.AWS_ACCESS_KEY_ID || "test";
options.secretAccessKey = process.env.AWS_SECRET_ACCESS_KEY || "test";
};

const patchProviderCredentials = (provider) => {
Expand Down