[CMB-501] Add snap packs, add outstanding missing resources #235
Conversation
There was a problem hiding this comment.
@richseviora So the main thing that stuck out to me is related to the tracking events. We are referencing the certified tracking events as opposed to the regular tracking events everywhere for snap packs.I had to fix this when working on the openapi docs: https://github.com/lob/lob-openapi/blob/main/resources/snap_packs/models/snap_pack.yml#L57
Snap packs do not accept extra_service as an argument (under which certified is an option). So, why do need to reference the certified tracking events as opposed to normal tracking events object? https://github.com/lob/lob-ruby/pull/235/files#diff-c32b967c6ec06599ed4be0df60c9fb428ca1613a5436ce0e7de94ab722a34fcfR21
docs/SnapPacksApi.md
Outdated
| include: ['inner_example'], # Array<String> | Request that the response include the total count by specifying `include[]=total_count`. | ||
| date_created: { key: Time.now}, # Hash<String, Time> | Filter by date created. | ||
| metadata: { key: 'inner_example'}, # Hash<String, String> | Filter by metadata key-value pair`. | ||
| size: [Lob::SnapPackSize::N6X18_BIFOLD], # Array<SnapPackSize> | The Snap Pack sizes to be returned. |
There was a problem hiding this comment.
We do not support this size with snap packs. Should we update such that we refer to the available sizes and not the self-mailer sizes?
This PR: