Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to quarto version 1.4.499 and add lightbox #53

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lnnrtwttkhn
Copy link
Owner

hi @konradpa,

this PR adds the lightbox image viewing option.
this requires to upgrade to quarto version 1.4.499 though, which is a pre-release version.

issues that I've discovered so far:

  • hamburger menu does not work on mobile
  • the "back" option at the end of the chapter looks weird (see below)

image

likely those issues will be fixed in future releases (and maybe we need to change something in our settings) but I am currently unsure whether we should merge this "only" to have access to the lightbox function.

@lnnrtwttkhn lnnrtwttkhn requested a review from konradpa October 27, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant