Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add behavior to handle unmapped muxes without constant inputs better #1869

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add behavior to handle unmapped muxes without constant inputs better #1869

wants to merge 2 commits into from

Conversation

fkosar-ql
Copy link
Collaborator

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

  • VPR
  • Tileable routing architecture generator
  • OpenFPGA libraries
  • FPGA-Verilog
  • FPGA-Bitstream
  • FPGA-SDC
  • FPGA-SPICE
  • Flow scripts
  • Architecture library
  • Cell library
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

tangxifan
tangxifan requested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@tangxifan tangxifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkosar-ql Thanks for the contribution. Can you add a dedicated testcase?

docs/source/manual/openfpga_shell/openfpga_commands/fpga_bitstream_commands.rst Outdated Show resolved Hide resolved
openfpga/src/base/openfpga_bitstream_template.h Outdated Show resolved Hide resolved
openfpga/src/fpga_bitstream/build_device_bitstream.cpp Outdated Show resolved Hide resolved
openfpga/src/fpga_bitstream/build_grid_bitstream.cpp Show resolved Hide resolved
openfpga/src/fpga_bitstream/build_grid_bitstream.cpp Outdated Show resolved Hide resolved
openfpga/src/fpga_bitstream/build_grid_bitstream.cpp Outdated Show resolved Hide resolved
openfpga/src/fpga_bitstream/build_grid_bitstream.cpp Outdated Show resolved Hide resolved
openfpga/src/fpga_bitstream/build_routing_bitstream.cpp Outdated Show resolved Hide resolved
openfpga/src/fpga_bitstream/build_routing_bitstream.cpp Outdated Show resolved Hide resolved
docs/source/manual/openfpga_shell/openfpga_commands/fpga_bitstream_commands.rst Outdated Show resolved Hide resolved
@fkosar-ql fkosar-ql force-pushed the unmapped-mux-selection branch from 7f95bda to cc18704 Compare October 31, 2024 07:02
@fkosar-ql fkosar-ql force-pushed the unmapped-mux-selection branch from e1acc5e to 1877779 Compare October 31, 2024 07:29
tangxifan
tangxifan reviewed Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@tangxifan tangxifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkosar-ql Can you add a testcase, and I can merge this PR.

@tangxifan
Copy link
Collaborator

@fkosar-ql One more thing. Can you document the mux decoding strategy here: https://openfpga.readthedocs.io/en/master/manual/arch_lang/circuit_model_examples/#cmdoption-arg-2

To the syntax add_const_input, comment on the impact when it is not enabled.

image

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangxifan tangxifan tangxifan requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
documentation openfpga-bitstream openfpga-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fkosar-ql @tangxifan @duck2