Bambi fix shape issues #534
Conversation
refactor: use fstring in error message
…ck-in-paramupdate Fix Param.update and add test case
…f-assert Fix validation and remove unnecessary assert statements
* adding new version of main tutorial * more improvements to tutorial * change install instructions * chainge warning settings * block bambi 0.14.0 * add exercise data * add no solution version of workshop * slight corrections * take out no-sol version * fix nan sigma values for categorical covariates * delete tutorial content that was not supposed to be part of this branch
src/hssm/hssm.py
Outdated
| elif (not isinstance(data, az.InferenceData)) and (data is not None): | ||
| raise ValueError("data must be an InferenceData object.") | ||
| elif data is None: | ||
| raise ValueError("Please sample to model first.") |
There was a problem hiding this comment.
For clarity, I'd use just one if block. We already have an assert statement to ensure that data is of type az.InferenceData, so just an else block that throws an error should be sufficient
There was a problem hiding this comment.
Ok thinking about the logic, I think we were able to just take the whole if logic out and rely on the fact that data must be InferenceData at this point anyways. @digicosmos86
There was a problem hiding this comment.
This needed to change in two places.
Will let the tests run now, then merge?
@AlexanderFengler also I am changing the merge target to the previous PR (fix InferenceData). We need to merge this one first before merging that one |
fixes failing tests in #522 .