Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update podspec version to 7.3.0 #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

artemsmikh
Copy link

@artemsmikh artemsmikh commented Nov 8, 2023

Hi, I guess the version in the .podspec file also need to be updated in order to push the changes to CocoaPods. I am asking anyone with the right permission to also add a tag 7.3.0 and push the new podspec to the CocoaPods trunk via pod trunk push GBDeviceInfo.podspec. Thanks!

@cpsauer
Copy link
Collaborator

cpsauer commented Nov 8, 2023

Hey, Artem! Have been discussing CocoaPods with Luka--and don't have permissions just yet. (Holding off on merge only so we're tracking that it hasn't been done; looks great to me; thanks for contributing.)

In the meantime, is there a good way to consume the latest commit directly from CocoaPods? (I'm actually using the code via a different mechanism.) I'm trying to think about ways we could automate or eliminate this step, since the latest commit is basically always what people want.

@artemsmikh
Copy link
Author

Hi @cpsauer, thanks! Yes, there is a way to do what you've said. You can specify a link to the repo directly in the Podfile like this:

pod 'GBDeviceInfo', :git => 'https://github.com/lmirosevic/GBDeviceInfo.git'

I'm using it like this now, since the version in the CocoaPods is outdated and doesn't have information about the newest iPhones. However, I'm not sure this is a good way to always use it like this, it's more like a hack until the repo owner pushes a new version to CocoaPods. You're right, many users would like to have the pod containing all the latest changes as soon as possible, but on the other hand, another thing that users expect is a certain level stability, and consistently relying on the latest commit sidesteps the stability and predictability that versioned releases provide.

@cpsauer cpsauer linked an issue Nov 10, 2023 that may be closed by this pull request
@cpsauer
Copy link
Collaborator

cpsauer commented Nov 10, 2023

(#152 is about the same. A little more discussion over there, but let's centralize here.)

Perhaps there's also a good way to do it per-commit and still keep reproducibility, either with cocoapods or with SPM? I'm not sure just how much SPM has taken over from pods, but while we're discussing this--and waiting for a call&permissions--I thought it might be worth discussing what primary distribution mechanism would be best in case it's changed.

(As in #152 (comment) IMO "living at head" can have some strong benefits, if (and only if) there's a natural way to consume libraries that way from Xcode. That is having the main branch represent the latest-and-greatest state, and people grabbing the latest by commit (reproducible) or branch (if it's a fast-and-loose kinda thing where they want auto updates). Benefit is that it equips everyone to go direct and easily hack on the project and contribute and keep things easily community maintained. But if it doesn't work smoothly from Xcode then we obviously shouldn't do that. Would love your all's opinion on what's best overall!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Releasing a new version
2 participants