-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Build and cache seprate Clang and GCC builds of LLVM #3242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandor
force-pushed
the
dev/nandor/separate-builds
branch
9 times, most recently
from
May 30, 2022 12:31
c099756
to
eaf1a25
Compare
dtzSiFive
reviewed
May 31, 2022
darthscsi
approved these changes
May 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When Will is happy, I'm happy.
teqdruid
reviewed
May 31, 2022
nandor
force-pushed
the
dev/nandor/separate-builds
branch
2 times, most recently
from
June 1, 2022 15:58
743da45
to
762d1f4
Compare
dtzSiFive
reviewed
Jun 1, 2022
dtzSiFive
reviewed
Jun 1, 2022
nandor
force-pushed
the
dev/nandor/separate-builds
branch
3 times, most recently
from
June 1, 2022 16:55
dfe22cc
to
88b3044
Compare
Code compiled with Clang cannot be linked with GCC due to incompatibilities related to lambda closure capture lists. This patch builds and caches LLVM with Clang to be used with the Clang Release build and with GCC to be used with the GCC Debug build of CIRCT. The ABI issue and a potential fix is being tracked here: itanium-cxx-abi/cxx-abi#141
nandor
force-pushed
the
dev/nandor/separate-builds
branch
from
June 1, 2022 16:58
88b3044
to
332c8ea
Compare
teqdruid
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code compiled with Clang cannot be linked with GCC due to incompatibilities related to lambda closure capture lists.
This patch builds and caches LLVM with Clang to be used with the Clang Release build and with GCC to be used with the GCC Debug build of CIRCT.
The ABI issue and a potential fix is being tracked here: itanium-cxx-abi/cxx-abi#141