Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Build and cache seprate Clang and GCC builds of LLVM #3242

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

nandor
Copy link
Contributor

@nandor nandor commented May 29, 2022

Code compiled with Clang cannot be linked with GCC due to incompatibilities related to lambda closure capture lists.

This patch builds and caches LLVM with Clang to be used with the Clang Release build and with GCC to be used with the GCC Debug build of CIRCT.

The ABI issue and a potential fix is being tracked here: itanium-cxx-abi/cxx-abi#141

@nandor nandor marked this pull request as draft May 29, 2022 17:11
@nandor nandor marked this pull request as ready for review May 29, 2022 17:18
@nandor nandor marked this pull request as draft May 29, 2022 17:19
@nandor nandor force-pushed the dev/nandor/separate-builds branch 9 times, most recently from c099756 to eaf1a25 Compare May 30, 2022 12:31
@nandor nandor marked this pull request as ready for review May 30, 2022 15:07
Copy link
Contributor

@darthscsi darthscsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When Will is happy, I'm happy.

@nandor nandor force-pushed the dev/nandor/separate-builds branch 2 times, most recently from 743da45 to 762d1f4 Compare June 1, 2022 15:58
@nandor nandor force-pushed the dev/nandor/separate-builds branch 3 times, most recently from dfe22cc to 88b3044 Compare June 1, 2022 16:55
Code compiled with Clang cannot be linked with GCC due to
incompatibilities related to lambda closure capture lists.

This patch builds and caches LLVM with Clang to be used
with the Clang Release build and with GCC to be used with
the GCC Debug build of CIRCT.

The ABI issue and a potential fix is being tracked here:
itanium-cxx-abi/cxx-abi#141
@nandor nandor force-pushed the dev/nandor/separate-builds branch from 88b3044 to 332c8ea Compare June 1, 2022 16:58
Copy link
Contributor

@teqdruid teqdruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@nandor nandor merged commit 6883750 into main Jun 2, 2022
@nandor nandor deleted the dev/nandor/separate-builds branch June 2, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants