Skip to content

Commit

Permalink
[llvm] bump (#3168)
Browse files Browse the repository at this point in the history
* https://reviews.llvm.org/D124717 changed optional attribute handling in the Python API
* https://reviews.llvm.org/D125604 catches misspelled FileCheck directives
  • Loading branch information
nandor authored May 28, 2022
1 parent e00cf85 commit 32d8134
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 8 deletions.
3 changes: 2 additions & 1 deletion lib/Bindings/Python/circt/dialects/_hw_ops_ext.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def __init__(self,
post_args = [
ArrayAttr.get([StringAttr.get(x) for x in self.operand_names()]),
ArrayAttr.get([StringAttr.get(x) for x in self.result_names()]),
ArrayAttr.get(inst_param_array), sym_name
ArrayAttr.get(inst_param_array)
]
if results is None:
results = module.type.results
Expand All @@ -86,6 +86,7 @@ def __init__(self,
pre_args,
post_args,
needs_result_type=True,
inner_sym=sym_name,
loc=loc,
ip=ip)

Expand Down
4 changes: 3 additions & 1 deletion lib/Bindings/Python/circt/dialects/_msft_ops_ext.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def __init__(self,
parameters = _hw_ext.create_parameters(parameters, module)
else:
parameters = []
post_args = [_ir.ArrayAttr.get(parameters), target_design_partition]
post_args = []
results = module.type.results

super().__init__(
Expand All @@ -41,6 +41,8 @@ def __init__(self,
input_port_mapping,
pre_args,
post_args,
parameters=_ir.ArrayAttr.get(parameters),
targetDesignPartition=target_design_partition,
loc=loc,
ip=ip,
)
Expand Down
2 changes: 1 addition & 1 deletion llvm
Submodule llvm updated 2830 files
4 changes: 2 additions & 2 deletions test/Dialect/FIRRTL/canonicalization.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -1679,7 +1679,7 @@ firrtl.module @add_cst_prop3(out %out_b: !firrtl.sint<4>) {
// CHECK: %[[pad:.+]] = firrtl.pad %tmp_a, 5
// CHECK-NEXT: firrtl.strictconnect %out_b, %[[pad]]
// CHECK-NEXT: %[[pad:.+]] = firrtl.pad %tmp_a, 5
// CHECK_NEXT: firrtl.strictconnect %out_b, %[[pad]]
// CHECK-NEXT: firrtl.strictconnect %out_b, %[[pad]]
firrtl.module @add_cst_prop4(out %out_b: !firrtl.uint<5>) {
%tmp_a = firrtl.wire : !firrtl.uint<4>
%invalid_ui4 = firrtl.invalidvalue : !firrtl.uint<4>
Expand All @@ -1693,7 +1693,7 @@ firrtl.module @add_cst_prop4(out %out_b: !firrtl.uint<5>) {
// CHECK: %[[pad:.+]] = firrtl.pad %tmp_a, 5
// CHECK-NEXT: firrtl.strictconnect %out_b, %[[pad]]
// CHECK-NEXT: %[[pad:.+]] = firrtl.pad %tmp_a, 5
// CHECK_NEXT: firrtl.strictconnect %out_b, %[[pad]]
// CHECK-NEXT: firrtl.strictconnect %out_b, %[[pad]]
firrtl.module @add_cst_prop5(out %out_b: !firrtl.uint<5>) {
%tmp_a = firrtl.wire : !firrtl.uint<4>
%c0_ui4 = firrtl.constant 0 : !firrtl.uint<4>
Expand Down
4 changes: 2 additions & 2 deletions test/Dialect/FIRRTL/imconstprop.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ firrtl.circuit "InstanceOut2" {
// -----

firrtl.circuit "invalidReg1" {
// CHECK_LABEL: @invalidReg1
// CHECK-LABEL: @invalidReg1
firrtl.module @invalidReg1(in %clock: !firrtl.clock, out %a: !firrtl.uint<1>) {
%foobar = firrtl.reg %clock : !firrtl.uint<1>
//CHECK: %0 = firrtl.not %foobar : (!firrtl.uint<1>) -> !firrtl.uint<1>
Expand All @@ -336,7 +336,7 @@ firrtl.circuit "invalidReg1" {
// -----

firrtl.circuit "invalidReg2" {
// CHECK_LABEL: @invalidReg2
// CHECK-LABEL: @invalidReg2
firrtl.module @invalidReg2(in %clock: !firrtl.clock, out %a: !firrtl.uint<1>) {
%foobar = firrtl.reg %clock : !firrtl.uint<1>
firrtl.connect %foobar, %foobar : !firrtl.uint<1>, !firrtl.uint<1>
Expand Down
2 changes: 1 addition & 1 deletion test/Dialect/FIRRTL/prefix-modules.mlir
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ firrtl.circuit "GCTDataMemTapsPrefix" {
// CHECK-SAME: annotations = [{circt.nonlocal = @nla_4, class = "nla_4"}]
// CHECK: %mem_MPORT_en = firrtl.wire sym @s1 {annotations = [{circt.nonlocal = @nla_2, class = "nla_2"}]} : !firrtl.uint<1>
// CHECK: firrtl.module @Baz()
// CHECK_SAME: annotations = [{circt.nonlocal = @nla_1, class = "nla_1"}, {circt.nonlocal = @nla_3, class = "nla_3"}]
// CHECK-SAME: annotations = [{circt.nonlocal = @nla_1, class = "nla_1"}, {circt.nonlocal = @nla_3, class = "nla_3"}]
// CHECK: %mem_MPORT_en = firrtl.wire sym @s1 : !firrtl.uint<1>

}
Expand Down

0 comments on commit 32d8134

Please sign in to comment.