Merge pull request #9 from llooker/tjbanghart/fixissues

Remove options issue
llooker · Sep 25, 2021 · 9eaf44a · 9eaf44a
2 parents 7b14dc8 + ca6842a
commit 9eaf44a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 20 deletions.
diff --git a/histogram.js b/histogram.js
diff --git a/src/common/options.js b/src/common/options.js
@@ -6,26 +6,16 @@ export const baseOptions = {
     section: "  Values",
     type: "string",
     order: 2,
-    display: "radio",
+    display: "select",
     values: [
       {
-        "Max Bins": {
-          description: "Set a maximum number of bins",
-          value: "bins",
-        },
+        "Max Bins": "bins"
       },
       {
-        Steps: {
-          description:
-            "Set an exact step size to use between bins. Step sizes that would create more than 50 bins are ignored.",
-          value: "steps",
-        },
+        Steps: "steps"
       },
       {
-        Breakpoints: {
-          description: "An array of allowable step sizes to choose from.",
-          value: "breakpoints",
-        },
+        Breakpoints: "breakpoints"
       },
     ],
     default: "bins",

diff --git a/src/histogram.js b/src/histogram.js
@@ -48,5 +48,6 @@ looker.plugins.visualizations.add({
 
       simpleHist(data, element, config, queryResponse, details, done, this, embed);
     }
+    done();
   },
 });
-Original file line number
+Diff line change
@@ Expand Up / @@ -48,5 +48,6 @@ looker.plugins.visualizations.add({ @@
           simpleHist(data, element, config, queryResponse, details, done, this, embed);
         }
+        done();
       },
     });