Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Refactored Engine::DoNextAction #854

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nl-saw
Copy link
Contributor

@nl-saw nl-saw commented Jan 6, 2025

Refactored Engine::DoNextAction so it is more performance-oriented. Mainly it applies multipliers early, which optimizes the action processing flow, and it exits the loop more efficiently when there’s no action to process.

I'd appreciate if some of you can test it to make sure there are no deficiencies in bot behavior.

No rush in merging :)

@blinkysc
Copy link
Contributor

blinkysc commented Jan 6, 2025

Putting on mine now

@blinkysc
Copy link
Contributor

blinkysc commented Jan 7, 2025

It seems stable for me. I still get sharp spikes, with the max percentiles reaching up to around 8,000 when using .server info, but this has been the status quo for quite some time.

@nl-saw
Copy link
Contributor Author

nl-saw commented Jan 7, 2025

It seems stable for me. I still get sharp spikes, with the max percentiles reaching up to around 8,000 when using .server info, but this has been the status quo for quite some time.

Thanks for the feedback, this is just a minor performance tune and will not help much with (huge) spikes.
Reason to test is to make sure the bot's behaviors are still intact.

@blinkysc
Copy link
Contributor

blinkysc commented Jan 7, 2025

It seems stable for me. I still get sharp spikes, with the max percentiles reaching up to around 8,000 when using .server info, but this has been the status quo for quite some time.

Thanks for the feedback, this is just a minor performance tune and will not help much with (huge) spikes. Reason to test is to make sure the bot's behaviors are still intact.

Everything has been same so far for bots. I am using new RPG strat though too, though not sure if that would be a big diff

@nl-saw
Copy link
Contributor Author

nl-saw commented Jan 7, 2025

Everything has been same so far for bots. I am using new RPG strat though too, though not sure if that would be a big diff

Thanks and no, bots use the do next action regardless of chosen strat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants