Skip to content

Commit

Permalink
webrtc-load-tester: Fix github action discord msg (#340)
Browse files Browse the repository at this point in the history
* wrtc-lt: Remove debug llog

* .github: Fix Discord notification format
  • Loading branch information
victorges authored Nov 15, 2023
1 parent cb2f136 commit 47d8e42
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 8 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/webrtc-load-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ jobs:
"value": "${{ inputs.duration }}",
"inline": true
}, {
"name": "Regional Viewers",
"value": "${{ inputs.playback-region-viewers-json }}",
"name": "Viewers",
"value": ${{ toJSON(inputs.playback-region-viewers-json) }},
"inline": true
}]
}]
Expand Down Expand Up @@ -141,7 +141,7 @@ jobs:
"value": "${{ inputs.duration }}",
"inline": true
}, {
"name": "Regional Viewers",
"name": "Viewers",
"value": ${{ toJSON(inputs.playback-region-viewers-json) }},
"inline": true
}]
Expand Down Expand Up @@ -171,7 +171,7 @@ jobs:
"value": "${{ inputs.duration }}",
"inline": true
}, {
"name": "Regional Viewers",
"name": "Viewers",
"value": ${{ toJSON(inputs.playback-region-viewers-json) }},
"inline": true
}]
Expand Down Expand Up @@ -201,7 +201,7 @@ jobs:
"value": "${{ inputs.duration }}",
"inline": true
}, {
"name": "Regional Viewers",
"name": "Viewers",
"value": ${{ toJSON(inputs.playback-region-viewers-json) }},
"inline": true
}]
Expand Down
1 change: 0 additions & 1 deletion cmd/webrtc-load-tester/roles/orchestrator.go
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ func Orchestrator() {
func initClients(cliFlags loadTestArguments) {
studioApi = api.NewAPIClient(api.ClientOptions{Server: cliFlags.APIServer, AccessToken: cliFlags.APIToken})

glog.Infof("Creating Google client with creds: %q", cliFlags.GoogleCredentialsJSON)
err := gcloud.InitClients(context.Background(), cliFlags.GoogleCredentialsJSON, cliFlags.GoogleProjectID)
if err != nil {
glog.Errorf("Error initializing cloud run client: %v", err)
Expand Down
2 changes: 0 additions & 2 deletions cmd/webrtc-load-tester/utils/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ func JSONVarFlag(fs *flag.FlagSet, dest interface{}, name, defaultValue, usage s
panic(err)
}
fs.Func(name, usage, func(s string) error {
glog.Infof("Setting %s to: %q", name, s)

// Clear any previously set value, including the default above
destVal := reflect.ValueOf(dest).Elem()
destVal.Set(reflect.Zero(destVal.Type()))
Expand Down

0 comments on commit 47d8e42

Please sign in to comment.