Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: views: fix streams by project filter #197

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

gioelecerati
Copy link
Member

  • Checking against stream.ProjectId instead of stream.UserID

@gioelecerati gioelecerati requested a review from a team as a code owner August 26, 2024 07:23
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.11864%. Comparing base (90f0aaa) to head (5383651).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
views/client.go 0.00000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##                main        #197   +/-   ##
=============================================
  Coverage   27.11864%   27.11864%           
=============================================
  Files              6           6           
  Lines            413         413           
=============================================
  Hits             112         112           
  Misses           286         286           
  Partials          15          15           
Files with missing lines Coverage Δ
views/client.go 19.86301% <0.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90f0aaa...5383651. Read the comment docs.

Files with missing lines Coverage Δ
views/client.go 19.86301% <0.00000%> (ø)

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol good catch

@gioelecerati gioelecerati merged commit 665bf99 into main Aug 30, 2024
11 of 13 checks passed
@gioelecerati gioelecerati deleted the gio/fix/views branch August 30, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants