Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add endpoint /views/internal/server/now #194

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Add endpoint /views/internal/server/now #194

merged 1 commit into from
Jun 20, 2024

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Jun 18, 2024

@leszko leszko requested review from thomshutt and victorges June 18, 2024 08:29
@leszko leszko requested a review from a team as a code owner June 18, 2024 08:29
@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 27.25061%. Comparing base (fb26320) to head (0e7f32f).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #194         +/-   ##
===================================================
- Coverage   28.07018%   27.25061%   -0.81957%     
===================================================
  Files              6           6                 
  Lines            399         411         +12     
===================================================
  Hits             112         112                 
- Misses           273         285         +12     
  Partials          14          14
Files Coverage Δ
views/client.go 19.86301% <0.00000%> (-1.00030%) ⬇️
views/prometheus.go 0.00000% <0.00000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb26320...0e7f32f. Read the comment docs.

Files Coverage Δ
views/client.go 19.86301% <0.00000%> (-1.00030%) ⬇️
views/prometheus.go 0.00000% <0.00000%> (ø)

@leszko leszko mentioned this pull request Jun 19, 2024
Merged
victorges
victorges approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

api/handler.go Show resolved Hide resolved
@leszko leszko merged commit b4b7663 into main Jun 20, 2024
13 checks passed
@leszko leszko deleted the rafal/server-now-endpoint branch June 20, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomshutt thomshutt thomshutt approved these changes

@victorges victorges victorges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leszko @thomshutt @victorges