Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add projectId to /data/queries #190

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Add projectId to /data/queries #190

merged 3 commits into from
Jun 3, 2024

Conversation

leszko
Copy link
Contributor

@leszko leszko commented May 24, 2024

With merging this PR we need to wait for the following parts:

  • @ecmulli to implement Clickpipes / SQL changes
  • @gioelecerati to implement projectId in /api/auth
  • @gioelecerati to fix returning projectId while listing assets/streams (also with admin token key)

fix https://linear.app/livepeer/issue/ENG-1980/add-filtering-by-projectid-in-livepeer-data

Copy link

linear bot commented May 24, 2024

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 28.07018%. Comparing base (7b3be19) to head (a614f8a).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #190         +/-   ##
===================================================
- Coverage   28.64450%   28.07018%   -0.57432%     
===================================================
  Files              6           6                 
  Lines            391         399          +8     
===================================================
  Hits             112         112                 
- Misses           265         273          +8     
  Partials          14          14                 
Files Coverage Δ
views/query_spec.go 71.42857% <ø> (ø)
views/clickhouse.go 0.00000% <0.00000%> (ø)
views/client.go 20.86331% <0.00000%> (-0.61817%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b3be19...a614f8a. Read the comment docs.

Files Coverage Δ
views/query_spec.go 71.42857% <ø> (ø)
views/clickhouse.go 0.00000% <0.00000%> (ø)
views/client.go 20.86331% <0.00000%> (-0.61817%) ⬇️

@leszko leszko requested review from victorges and ecmulli May 24, 2024 10:33
@ecmulli
Copy link
Member

ecmulli commented May 24, 2024

@leszko leszko marked this pull request as ready for review June 3, 2024 13:10
@leszko leszko requested a review from a team as a code owner June 3, 2024 13:10
@leszko leszko merged commit 73d4236 into main Jun 3, 2024
13 checks passed
@leszko leszko deleted the rafal/add-project-id branch June 3, 2024 14:04
@victorges
Copy link
Member

victorges commented Jun 5, 2024

Reverting this on main branch since the the other parts necessary for these are not deployed yet as far as I can tell. We need to deploy the analyzer service now and the main branch is blocked, so let's free it up until this can actually go to prod.

victorges added a commit that referenced this pull request Jun 5, 2024
leszko added a commit that referenced this pull request Jun 6, 2024
leszko added a commit that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants