Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare code for a new image processor #30

Merged
merged 8 commits into from
Nov 8, 2024
Merged

feat: prepare code for a new image processor #30

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5b006a9
refactor: remove the implementation detail from gamma spec
knarewski Nov 1, 2024
59037f7
test: add tolerance to result of output.limit
knarewski Nov 1, 2024
e4cd693
test: relax the requirements for error raised when provided file is e…
knarewski Nov 1, 2024
63937e6
refactor: move some specs into a dedicated shared examples block
knarewski Nov 1, 2024
7fb04c1
fix: style
knarewski Nov 1, 2024
112c0e6
fix: docs corrections
knarewski Nov 7, 2024
5fea4f7
fix: correct the spec name to prevent overwriting
knarewski Nov 7, 2024
3d10e03
test: use rspec matchers instead of a custom block for error assertion
knarewski Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ Metrics/BlockLength:
AllowedMethods:
- describe
- context
- shared_examples

# Offense count: 1
# Configuration parameters: CountComments, CountAsOne.
Expand Down
4 changes: 2 additions & 2 deletions lib/morandi.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ module Morandi
# @option options [Array[Integer,Integer,Integer,Integer]] 'crop' Crop image (x, y, width, height)
# @option options [String] 'fx' Apply colour filters ('greyscale', 'sepia', 'bluetone')
# @option options [String] 'border-style' Set border style ('square', 'retro')
# @option options [String] 'background-style' Set border colour ('retro', 'black', 'white')
# @option options [String] 'quality' ('97') Set JPG compression value ('1' to '100')
# @option options [String] 'background-style' Set border colour ('retro', 'black', 'white', 'dominant')
# @option options [Integer] 'quality' (97) Set JPG compression value (1 to 100)
# @option options [Integer] 'output.max' Downscales the image to fit within the square of given size before
# processing to limit the required resources
# @option options [Integer] 'output.width' Sets desired width of resulting image
Expand Down
Loading