Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only play room join audio if already asked for pin #47

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Jan 11, 2024

No description provided.

@dennwc dennwc requested a review from Sean-Der January 11, 2024 16:28
@dennwc dennwc self-assigned this Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b75ef51) 24.23% compared to head (56f7e4b) 24.23%.
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/sip/inbound.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   24.23%   24.23%           
=======================================
  Files          21       21           
  Lines        1766     1766           
=======================================
  Hits          428      428           
  Misses       1311     1311           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennwc dennwc merged commit 298649e into main Jan 11, 2024
3 of 4 checks passed
@dennwc dennwc deleted the public_no_join_audio branch January 11, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants