Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce cardinality of invite error metric. #40

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Reduce cardinality of invite error metric. #40

merged 1 commit into from
Dec 29, 2023

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Dec 29, 2023

No description provided.

@dennwc dennwc requested a review from Sean-Der December 29, 2023 15:15
@dennwc dennwc self-assigned this Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bb81f38) 24.23% compared to head (d2f76b8) 24.60%.

Files Patch % Lines
pkg/sip/inbound.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   24.23%   24.60%   +0.36%     
==========================================
  Files          21       21              
  Lines        1737     1752      +15     
==========================================
+ Hits          421      431      +10     
- Misses       1289     1293       +4     
- Partials       27       28       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennwc dennwc merged commit d6393c3 into main Dec 29, 2023
5 checks passed
@dennwc dennwc deleted the invite_metric branch December 29, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants