Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic call metrics #29

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Add basic call metrics #29

merged 1 commit into from
Dec 16, 2023

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Dec 15, 2023

No description provided.

@dennwc dennwc requested a review from Sean-Der December 15, 2023 16:02
@dennwc dennwc self-assigned this Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (634148a) 18.51% compared to head (849893d) 21.93%.

Files Patch % Lines
pkg/stats/monitor.go 79.22% 15 Missing and 1 partial ⚠️
pkg/sip/inbound.go 37.50% 5 Missing ⚠️
pkg/sip/service.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   18.51%   21.93%   +3.42%     
==========================================
  Files          19       20       +1     
  Lines        1464     1559      +95     
==========================================
+ Hits          271      342      +71     
- Misses       1167     1189      +22     
- Partials       26       28       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennwc dennwc merged commit b1e6972 into main Dec 16, 2023
5 checks passed
@dennwc dennwc deleted the metrics branch December 16, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants