Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS support #210

Merged
merged 1 commit into from
Oct 24, 2024
Merged

TLS support #210

merged 1 commit into from
Oct 24, 2024

Conversation

dennwc
Copy link
Contributor

@dennwc dennwc commented Oct 24, 2024

Add TLS support for signaling. Resolves #71.

@dennwc dennwc self-assigned this Oct 24, 2024
@dennwc dennwc requested a review from a team as a code owner October 24, 2024 17:22
contactHeader := &sip.ContactHeader{Address: sip.Uri{Host: c.s.signalingIp.String(), Port: c.s.conf.SIPPort}}

req := NewReferRequest(c.invite, c.inviteOk, contactHeader, transferTo)
req := NewReferRequest(c.invite, c.inviteOk, c.contact, transferTo)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@@ -75,6 +75,7 @@ func (v CallStatus) DisconnectReason() livekit.DisconnectReason {

const (
callDropped = CallStatus(iota)
callFlood
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constant should not be exported?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't distinguish it in participant attributes, so it's unexported.

@dennwc dennwc merged commit 0460b40 into main Oct 24, 2024
3 checks passed
@dennwc dennwc deleted the tls branch October 24, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCP/TLS support for SIP signaling
2 participants