Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't stop the room receive loop on exception #63

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: don't stop the room receive loop on exception #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion livekit/room.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,12 @@ async def _listen_task(self) -> None:

event = wait_event_future.result()
if event.room_event.room_handle == self._ffi_handle.handle: # type: ignore
self._on_room_event(event.room_event)
try:
self._on_room_event(event.room_event)
except Exception as e:
logging.error(
'error running user callback for %s: %s',
event.room_event.WhichOneof('message'), e)

# wait for the subscribers to process the event
# before processing the next one
Expand Down