fix: keep events order #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theomonnom
commented
Sep 12, 2023
theomonnom
commented
Sep 12, 2023
|
it's tricky, now with the changes, we can't publish tracks before running room.run() ... |
davidzhao
reviewed
Sep 13, 2023
davidzhao
approved these changes
Sep 13, 2023
| @@ -64,6 +70,7 @@ def name(self) -> str: | |||
| def metadata(self) -> str: | |||
| return self._info.metadata | |||
|
|
|||
| @property | |||
| def e2ee_manager(self) -> E2EEManager: | |||
There was a problem hiding this comment.
would this change the interface? let's document in changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalTrackPublishedcallback is sent before theLocalTrackPublishedeventThe room musts be used inside one event_loop (specified inside the ctor)
AudioStream & VideoStream can be used on other event_loops (making it easy to have another IO thread for e.g)