Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix av sync example #338

Merged
merged 7 commits into from
Jan 3, 2025
Merged

fix av sync example #338

merged 7 commits into from
Jan 3, 2025
+101 −28

Conversation

longcw
Copy link
Contributor

@longcw longcw commented Dec 30, 2024 •
edited
Loading

Improved the video play example:

  1. log the timestamps of the video and audio frames
  2. add reset for av sync after the video finished

@longcw longcw changed the title [draft] fixing av sync fix av sync example Dec 30, 2024
davidzhao
davidzhao approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version seems to resolve the sync issues that I had. lg.

@longcw longcw merged commit 244e2fc into main Jan 3, 2025
12 checks passed
@longcw longcw deleted the longc/testing-av-sync branch January 3, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@longcw @davidzhao