Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed unpublish track error by adding stop_on_unpublish value #325

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fixed unpublish track error by adding stop_on_unpublish value #325

merged 1 commit into from
Dec 11, 2024

Conversation

s-hamdananwar
Copy link
Contributor

fixes #317

@s-hamdananwar s-hamdananwar requested a review from a team December 11, 2024 22:14
davidzhao
davidzhao approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@s-hamdananwar s-hamdananwar merged commit c0b1e1c into main Dec 11, 2024
12 checks passed
@s-hamdananwar s-hamdananwar deleted the hamdan/fix-track-unpublish-error branch December 11, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task exception error when calling local_participant.unpublish_track
2 participants
@s-hamdananwar @davidzhao