Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve & expose EventEmitter #284

Merged
merged 1 commit into from
Oct 9, 2024
Merged

improve & expose EventEmitter #284

merged 1 commit into from
Oct 9, 2024

Conversation

theomonnom
Copy link
Member

@theomonnom theomonnom commented Oct 9, 2024 •
edited
Loading

  • exposed for use in agents
  • avoid throwing errors when the callback doesn't have the same parameter count (we just ignore the arguments that aren't specified)
  • continue to call other callbacks if one of them fail
  • add docs

@theomonnom theomonnom requested a review from a team October 9, 2024 23:03
@theomonnom theomonnom merged commit 135edaa into main Oct 9, 2024
11 checks passed
@theomonnom theomonnom deleted the theo/event-emitter-improvements branch October 9, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keepingitneil keepingitneil keepingitneil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theomonnom @keepingitneil