Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC implementation via FFI #283

Merged
merged 59 commits into from
Oct 30, 2024
Merged

RPC implementation via FFI #283

merged 59 commits into from
Oct 30, 2024

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented Oct 8, 2024

This is a full implementation of the native RPC spec based on Rust FFI livekit/rust-sdks#461

It includes documentation and a complete working example.

@bcherry bcherry changed the title [WIP] RPC RPC implementation on FFI Oct 8, 2024
@bcherry bcherry changed the title RPC implementation on FFI RPC implementation via FFI Oct 8, 2024
@bcherry bcherry marked this pull request as ready for review October 8, 2024 23:11
@bcherry bcherry requested a review from theomonnom October 28, 2024 19:39
@bcherry bcherry requested review from theomonnom and removed request for theomonnom October 28, 2024 21:01
Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

nit: CI is failing

livekit-rtc/livekit/rtc/room.py Outdated Show resolved Hide resolved
@bcherry bcherry merged commit 1ef5db5 into main Oct 30, 2024
12 checks passed
@bcherry bcherry deleted the bcherry/rpc branch October 30, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants