Update rust ffi #217
Merged
Update rust ffi #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theomonnom
reviewed
Jul 16, 2024
davidzhao
reviewed
Jul 16, 2024
davidzhao
approved these changes
Jul 16, 2024
| self.emit("track_published", rpublication, rparticipant) | ||
| elif which == "track_unpublished": | ||
| rparticipant = self.participants[event.track_unpublished.participant_sid] | ||
| rpublication = rparticipant.tracks.pop( | ||
| rparticipant = self.remote_participants[ |
There was a problem hiding this comment.
nit: I think we should always use .get() on these to guard against the object not being present. if participant is removed, it'd be better to handle the None responses.
There was a problem hiding this comment.
@theomonnom is it possible for track_unpublished (and friends) to come after the participant has been disconnected. I'm not super familiar with the async rust stuff and what guarantees we have for ffi events.
theomonnom
reviewed
Jul 17, 2024
| @@ -88,13 +91,14 @@ def __init__( | |||
| ) -> None: | |||
| super().__init__(owned_info) | |||
| self._room_queue = room_queue | |||
| self.tracks: dict[str, LocalTrackPublication] = {} # type: ignore | |||
| self.track_publications: dict[str, LocalTrackPublication] = {} # type: ignore | |||
|
|
|||
| async def publish_data( | |||
| self, | |||
| payload: Union[bytes, str], | |||
There was a problem hiding this comment.
should payload be positional?
There was a problem hiding this comment.
I like it positional because it's the only value with no default so it's really convenient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.