Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

room: allow RemoteParticipant to be None #215

Merged
merged 4 commits into from
Jul 6, 2024
Merged

Conversation

nbsp
Copy link
Member

@nbsp nbsp commented Jul 6, 2024

should fix the bug when receiving messages from the server: this allows Python to fail gracefully to retrieve the remote participant.

@nbsp nbsp requested review from davidzhao and theomonnom July 6, 2024 02:27
@davidzhao
Copy link
Member

looks like we need to update the return type too

Copy link
Member

@theomonnom theomonnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, CI doesn't pass tho

@nbsp nbsp force-pushed the nbsp/remote-participant-none branch 2 times, most recently from 9152138 to e1bdb3a Compare July 6, 2024 03:01
@nbsp nbsp force-pushed the nbsp/remote-participant-none branch from e1bdb3a to dc46623 Compare July 6, 2024 03:07
@nbsp
Copy link
Member Author

nbsp commented Jul 6, 2024

unsure why this is still erroring, i've got assert isinstance guards there..

@davidzhao
Copy link
Member

unsure why this is still erroring, i've got assert isinstance guards there..

have you tried isinstance(obj, Participant) or if obj is not None ?

@nbsp
Copy link
Member Author

nbsp commented Jul 6, 2024

unsure why this is still erroring, i've got assert isinstance guards there..

have you tried isinstance(obj, Participant) or if obj is not None ?

found a fix by using typing.cast

@nbsp nbsp merged commit d8f02ec into main Jul 6, 2024
11 checks passed
@nbsp nbsp deleted the nbsp/remote-participant-none branch July 6, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants