Update protocol. Support SIP inbound/outbound trunks, grants. #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
theomonnom
reviewed
Jun 20, 2024
|
Type checks aren't passing |
dennwc
force-pushed
the
sip-update
branch
2 times, most recently
from
c88cdc1 to
21cf83f
Compare
|
It's weird that the checks do not appear on the PR 🤔 |
|
Should be good now. @theomonnom could you double check? Something wrong with WebRTC builds though... |
theomonnom
reviewed
Jun 21, 2024
This reverts commit d2ca4f7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update protocol. Add support for inbound/outbound SIP trunks and set token grants.
Please check the token construction, I'm not sure I added everything required for new
sipclaim field.