feat: support topic on data packets #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keepingitneil
approved these changes
Dec 4, 2023
davidzhao
reviewed
Dec 4, 2023
| @@ -80,7 +80,8 @@ async def publish_data( | |||
| self, | |||
| payload: Union[bytes, str], | |||
| kind: DataPacketKind.ValueType = DataPacketKind.KIND_RELIABLE, | |||
| destination_sids: Optional[List[Union[str, "RemoteParticipant"]]] = None, | |||
| destination_sids: List[Union[str, "RemoteParticipant"]] = [], | |||
There was a problem hiding this comment.
should we switch to identities now?
davidzhao
reviewed
Dec 15, 2023
| data, | ||
| event.data_received.kind, | ||
| rparticipant, | ||
| event.data_received.topic, |
There was a problem hiding this comment.
This is problematic to add arguments to callbacks.. my code was just broken with this error:
TypeError: on_data_received() takes 4 positional arguments but 5 were given
we really need to either:
- avoid changing callback parameters
- pass back an object that can be modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.