use env at runtime

livekit · Dec 4, 2023 · 50c86f0 · 50c86f0
1 parent a13ab4c
commit 50c86f0
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 9 deletions.
diff --git a/examples/face_landmark/face_landmarker.task b/examples/face_landmark/face_landmarker.task
diff --git a/livekit-api/livekit/api/access_token.py b/livekit-api/livekit/api/access_token.py
@@ -74,14 +74,21 @@ class Claims:
 class AccessToken:
     def __init__(
         self,
-        api_key: str = os.getenv("LIVEKIT_API_KEY", ""),
-        api_secret: str = os.getenv("LIVEKIT_API_SECRET", ""),
+        api_key: Optional[str] = None,
+        api_secret: Optional[str] = None,
     ) -> None:
+        if not api_key:
+            api_key = os.getenv("LIVEKIT_API_KEY", "")
+
+        if not api_secret:
+            api_secret = os.getenv("LIVEKIT_API_SECRET", "")
+
+        if not api_key or not api_secret:
+            raise ValueError("api_key and api_secret must be set")
+
         self.api_key = api_key  # iss
         self.api_secret = api_secret
         self.claims = Claims()
-        if not api_key or not api_secret:
-            raise ValueError("api_key and api_secret must be set")
 
         # default jwt claims
         self.identity = ""  # sub
@@ -137,11 +144,20 @@ def to_jwt(self) -> str:
 class TokenVerifier:
     def __init__(
         self,
-        api_key: str = os.getenv("LIVEKIT_API_KEY", ""),
-        api_secret: str = os.getenv("LIVEKIT_API_SECRET", ""),
+        api_key: Optional[str] = None,
+        api_secret: Optional[str] = None,
         *,
         leeway: datetime.timedelta = DEFAULT_LEEWAY,
     ) -> None:
+        if not api_key:
+            api_key = os.getenv("LIVEKIT_API_KEY", "")
+
+        if not api_secret:
+            api_secret = os.getenv("LIVEKIT_API_SECRET", "")
+
+        if not api_key or not api_secret:
+            raise ValueError("api_key and api_secret must be set")
+
         self.api_key = api_key
         self.api_secret = api_secret
         self._leeway = leeway

diff --git a/livekit-api/livekit/api/livekit_api.py b/livekit-api/livekit/api/livekit_api.py
@@ -8,12 +8,27 @@
 class LiveKitAPI:
     def __init__(
         self,
-        url: str = os.getenv("LIVEKIT_URL", "http://localhost:7880"),
-        api_key: str = os.getenv("LIVEKIT_API_KEY", ""),
-        api_secret: str = os.getenv("LIVEKIT_API_SECRET", ""),
+        url: Optional[str] = None,
+        api_key: Optional[str] = None,
+        api_secret: Optional[str] = None,
         *,
         timeout: float = 60,  # 1 minutes by default
     ):
+        if not url:
+            url = os.getenv("LIVEKIT_URL", "")
+
+        if not api_key:
+            api_key = os.getenv("LIVEKIT_API_KEY", "")
+
+        if not api_secret:
+            api_secret = os.getenv("LIVEKIT_API_SECRET", "")
+
+        if not url:
+            raise ValueError("url must be set")
+
+        if not api_key or not api_secret:
+            raise ValueError("api_key and api_secret must be set")
+
         self._session = aiohttp.ClientSession(timeout=timeout)
         self._room = RoomService(url, api_key, api_secret, self._session)
         self._ingress = IngressService(url, api_key, api_secret, self._session)