Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experimental feature of audio muxing #614

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Experimental feature of audio muxing #614

wants to merge 3 commits into from
+358 −1

Conversation

cnderrauber
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023

⚠️ No Changeset found

Latest commit: 71c1bca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

lukasIO
lukasIO reviewed Mar 10, 2023
View reviewed changes
src/room/track/MuxedRemoteAudioTrack.ts
audioOutput?: AudioOutputOptions,
) {
if (!audioContext) {
audioContext = new AudioContext()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we create one audio context on room level if muxing is enabled instead of a new one for each track?

lukasIO
lukasIO reviewed Mar 10, 2023
View reviewed changes
src/room/track/MuxedRemoteAudioTrack.ts
this.audioCtx = audioContext;
this.streamDst = dst;
this.streamDstTrack = streamDstTrack;
this.audioForWebRTCStream = new Audio();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might make sense to mute this element explicitly, just to be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasIO lukasIO lukasIO left review comments

@davidzhao davidzhao Awaiting requested review from davidzhao

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnderrauber @lukasIO