Handle errors thrown in signal client callbacks #1063
Conversation
🦋 Changeset detectedLatest commit: 3e5e096 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| log.error(`failed to setPublisherAnswer: ${errorMessage}`, { | ||
| ...this.logContext, | ||
| RTCSdpType: sd.type, | ||
| }); |
There was a problem hiding this comment.
this should probably trigger a reconnect
There was a problem hiding this comment.
I looked into it again, and it looks like I'm not going to catch an InvalidStateError here at all, and instead I will get a NegotiationError. Should I look for it instead? This looks like an oddly specific error to handle and to try reconnect on.
| @@ -456,16 +465,30 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit | |||
| return; | |||
| } | |||
| this.log.trace('got ICE candidate from peer', { ...this.logContext, candidate, target }); | |||
| this.pcManager.addIceCandidate(candidate, target); | |||
| this.pcManager.addIceCandidate(candidate, target).catch((error) => { | |||
There was a problem hiding this comment.
in case of an InvalidStateError this should probably also trigger a reconnect
| try { | ||
| const answer = await this.pcManager.createSubscriberAnswerFromOffer(sd); | ||
| await this.client.sendAnswer(answer); | ||
| } catch (error) { |
HermanBilous
changed the title
HermanBilous
changed the title
|
Added handling of |
|
@lukasIO, could you please take a look? I need a hint. |
No description provided.