fix: Fix wrong override when options is not null when LocalTrack.create.

livekit · Jun 21, 2023 · dc1d8fb · dc1d8fb · furkanKotic · Jun 21, 2023
1 parent c02fad6
commit dc1d8fb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/lib/src/track/local/audio.dart b/lib/src/track/local/audio.dart
@@ -99,7 +99,7 @@ class LocalAudioTrack extends LocalTrack
   static Future<LocalAudioTrack> create([
     AudioCaptureOptions? options,
   ]) async {
-    options = const AudioCaptureOptions();
+    options ??= const AudioCaptureOptions();
     final stream = await LocalTrack.createStream(options);
 
     return LocalAudioTrack(

diff --git a/lib/src/track/local/video.dart b/lib/src/track/local/video.dart
@@ -128,7 +128,7 @@ class LocalVideoTrack extends LocalTrack with VideoTrack {
   static Future<LocalVideoTrack> createCameraTrack([
     CameraCaptureOptions? options,
   ]) async {
-    options = const CameraCaptureOptions();
+    options ??= const CameraCaptureOptions();
 
     final stream = await LocalTrack.createStream(options);
     return LocalVideoTrack._(
@@ -165,8 +165,11 @@ class LocalVideoTrack extends LocalTrack with VideoTrack {
   static Future<List<LocalTrack>> createScreenShareTracksWithAudio([
     ScreenShareCaptureOptions? options,
   ]) async {
-    options = const ScreenShareCaptureOptions(captureScreenAudio: true);
-
+    if (options == null) {
+      options = const ScreenShareCaptureOptions(captureScreenAudio: true);
+    } else {
+      options = options.copyWith(captureScreenAudio: true);
+    }
     final stream = await LocalTrack.createStream(options);
 
     List<LocalTrack> tracks = [