Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change toNumber error message for non-alphabetical char #5

Open
wants to merge 1 commit into
base: travis
Choose a base branch
from
Open

Change toNumber error message for non-alphabetical char #5

wants to merge 1 commit into from

Conversation

livecodeali
Copy link
Owner

No description provided.

@livecodeali
Copy link
Owner Author

From the test log:

not ok - non alphabetic input to toNumber function throws
# Expected error: char not alphabetical
# Actual error: char not in the range A to Z

livecodeali
livecodeali commented May 10, 2019
View reviewed changes
src/PuzzleTools.livecodescript
@@ -4,7 +4,7 @@ function toNumber pChar
local tNum
put chartonum(toUpper(pChar)) - 64 into tNum
if tNum < 1 or tNum > 26 then
throw "char not alphabetical"
throw "char not in the range A to Z"
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error tested for in TestLetterToNumber needs to be changed accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@livecodeali