This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Add support for new device sizes in new stack templates #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds support for new device sizes in new stack templates, both in the 'New File' menu and the in the start center.
livecodepanos
force-pushed
the
update_ide_new_file_menu
branch
from
1f683f8 to
de99f27
Compare
| @@ -1364,16 +1364,39 @@ private function revMenubarFileMenu pContext | |||
| put true into tCanSaveStack | |||
| end if | |||
|
|
|||
| local sDeviceList | |||
| put \ | |||
| "Generic Android 6-inch Phone (412,775)" & return & \ | |||
There was a problem hiding this comment.
all the iOS ones use x rather than ,
There was a problem hiding this comment.
really would be better as a configuration file somewhere
| "Generic Android 6-inch Phone (412,775)" & return & \ | ||
| "Generic Android 7-inch Phablet (600, 1024)" & return & \ | ||
| "Generic Android 10-inch Tablet Portrait (720,1280)" & return & \ | ||
| "Generic Android 10-inch Tablet Landscape 1280,720)" & return & \ |
| local sDeviceList | ||
| put \ | ||
| "Generic Android 6-inch Phone (412,775)" & return & \ | ||
| "Generic Android 7-inch Phablet (600, 1024)" & return & \ |
There was a problem hiding this comment.
extra space here compared to others
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for new device sizes in new stack templates, both in the 'New File' menu and the in the start center.
Start Center:
After pressing "New" in Start Center:
After pressing "Tablet Portrait":
After pressing "Tablet Landscape":
After pressing "Phone":