Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Bugfix 22798 #2136

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Bugfix 22798 #2136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47f395e
[[ Bug 22285 ]] Restrict selection of key field in customprops editor
livecodeali May 13, 2020
8a050f0
Merge pull request #2133 from livecode/bugfix-22285
livecodepanos May 15, 2020
7dd74e7
Merge pull request #2134 from livecode/merge-release-9.6.0-19.05.2020
livecodepanos May 25, 2020
394910d
fix delayTouches
macMikey Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Toolset/palettes/inspector/editors/com.livecode.pi.customprops.behavior.livecodescript
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
script "com.livecode.pi.customprops.behavior"
local sPropSet, sHilitePath
local sPropSet, sHilitePath, sReselect

on editorInitialize
put empty into sPropSet
put false into sReselect
put the editorLabel of me into field "rowlabel" of me
set the rowShowLabel of me to false
set the label of button "customPropertySet" of group "Set buttons" of me to "customKeys"
Expand Down Expand Up @@ -69,7 +70,10 @@ on editorUpdate
if the result is empty then
put tKey into field "value" of me
put item -1 of tPath into field "key" of me
select the text of field "key" of me
if sReselect then
select the text of field "key" of me
put false into sReselect
end if
else
put empty into field "key" of me
put empty into field "value" of me
Expand Down Expand Up @@ -371,6 +375,7 @@ function revValidSetName pWhich
end revValidSetName

on hiliteChanged
put true into sReselect
checkRehilite
editorUpdate
put empty into sHilitePath
Expand Down
2 changes: 1 addition & 1 deletion Toolset/palettes/revdatagridlibrary/behaviorsdatagridbuttonbehavior.livecodescript
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ private command _CreateMobileScroller
mobileControlSet sScrollerId, "canBounce", "true"
mobileControlSet sScrollerId, "pagingEnabled", "false"
mobileControlSet sScrollerId, "canScrollToTop", "true"
mobileControlSet sScrollerId, "delayTouches", "false"
mobileControlSet sScrollerId, "delayTouches", "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this rather be merged into develop-9.6 to up its priority/urgency?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I didn't see a 9.6 branch open and
nobody else commented on the how list and
nobody else commented on the bug report and
this has been like this since whenever dg2 came out but nobody else seemed to notice, so I'm going with "maybe".
I mean, I personally think it should be a hotfix and get a special code name and a bug bounty Bond car to me and a lifetime free subscription to every LC premium thing, but I'm also megalomaniac.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Mikey: this bug is driving me nuts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't hold your breath waiting for a pull request to be reviewed.
Meanwhile, this is a stack-only script, so you can always patch your own copy.

mobileControlSet sScrollerId, "canCancelTouches", "true"
__PollVisibility
end if
Expand Down
1 change: 1 addition & 0 deletions notes/bugfix-22285.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# Only reselect key field in customprops editor in response to a change in hilite