This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[Bug 22211] Remove unnecessary 'unlock cursor' in ideMouseMove #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes a seemingly unnecessary `unlock cursor` in the IDE's mouseMove event handler (`ideMouseMove`). The IDE intercepts mouseMove so that it can update the resize cursor used when the mouse is over the relevant selection handlers. It does this by locking the cursor in this case and then changing the cursor appropriately; unlocking the cursor when there is a selected object and the mouse is not over a selection handle. Previously it would also unlock the cursor if pointer tool was in effect and there was no selected object which (because the handler is executed in time after any user handlers) would undo any user use of `lock cursor`. This fixes bug 22211 and bug 18428 and avoids the problems of a fix for these in livecode#2092
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes a seemingly unnecessary
unlock cursorin the IDE'smouseMove event handler (
ideMouseMove).The IDE intercepts mouseMove so that it can update the resize cursor
used when the mouse is over the relevant selection handlers. It does this
by locking the cursor in this case and then changing the cursor
appropriately; unlocking the cursor when there is a selected object and
the mouse is not over a selection handle.
Previously it would also unlock the cursor if pointer tool was in effect and
there was no selected object which (because the handler is executed in
time after any user handlers) would undo any user use of
lock cursor.This fixes bug 22211 and bug 18428 and avoids the problems of a fix for these in
#2092