This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[22205] Ensure the check for IDE stacks is accurate #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch ensures that user stacks with names similar to the leaf name of IDE library stacks (e.g. "drawing", "diff" etc) are no longer treated as IDE stacks. The check if the stack name is among the lines of revInternal__ListLoadedLibraries() was removed, as all the stacks included in this list have either their _ideoverride set to true, or begin with "rev". The only exception to this is tsNetLibURL, so for this reason its _ideoverride property is set when this stack is loaded (i.e. in revInternal__LoadIfLibrary)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes bug 22205
This patch ensures that user stacks with names similar to the leaf name of IDE library stacks (e.g. "drawing", "diff" etc) are no longer treated as IDE stacks. The check if the stack name is among the lines of
revInternal__ListLoadedLibraries()was removed, as all the stacks included in this list either already have their_ideoverrideset to true, or begin with "rev". The only exception to this istsNetLibURL, so for this reason its_ideoverrideproperty is set when this stack is loaded (i.e. inrevInternal__LoadIfLibrary)