Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Make some IDE stacks to come to the front rather than closing #2029

Open
wants to merge 1 commit into
base: develop-9.0
Choose a base branch
from
Open

Make some IDE stacks to come to the front rather than closing #2029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Toolset/libraries/revidelibrary.8.livecodescript
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8861,9 +8861,11 @@ end revIDEToggleShowIDEStacksInLists
on revIDETogglePalette pPaletteName
local tStackName
put revIDEPaletteToStackName(pPaletteName) into tStackName

if the mode of stack tStackName is 0 or the visible of stack tStackName is false then
revIDEOpenPalette pPaletteName
else if tStackName is not line 1 of the openStacks then
go card 1 of stack tStackName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@livecodepanos I'm not sure about this patch because the toggle is meant to open and close the IDE stacks, however, I can imagine (I'm pretty sure I've done it) using the toggle when the target stack is obscured by other stacks. This is really what the Window menu is meant to do but that doesn't list all IDE stacks.

I would suggest the following:

  • update revIDEStackIsIDEWindow to include any modeless or toplevel (if there are any) IDE stacks so that these stacks appear in the Window menu
  • implement a function revIDEStackIsObscured to determine if the user can't see the stack because it is obscured by the rects of other stacks.
  • use revIDESendWindowToFront to raise the window in revIDETogglePalette if it is among the lines of the openStacks and revIDEStackIsObscured

else
close stack tStackName
end if
Expand Down