Update export flow for JS outputs #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uffizzi Preview |
jonatanklosko
force-pushed
the
jk-export
branch
from
96359ea
to
565521c
Compare
josevalim
reviewed
Aug 26, 2023
| @@ -52,6 +56,26 @@ defmodule Livebook.LiveMarkdown.Export do | |||
| data | |||
| end | |||
|
|
|||
| # Handle old flow for backward compatibility with Kino <= 0.10.0 | |||
There was a problem hiding this comment.
Do we want to add a TODO to eventually remove it?
There was a problem hiding this comment.
I wasn't sure, but yeah it's not critical, worst case we just don't export the output when someone uses an old kino. I added a TODO to remove on livebook v0.13, which should be enough time :)
josevalim
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See livebook-dev/kino#321.