Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kino.recompile/0 #399

Merged
merged 3 commits into from
Feb 29, 2024
Merged

Add Kino.recompile/0 #399

merged 3 commits into from
Feb 29, 2024

Conversation

jonatanklosko
Copy link
Member

🐈

@hugobarauna
Copy link
Member

hugobarauna commented Feb 29, 2024

Awesome!

Out of curiosity: why is this in Kino?

lib/kino.ex Outdated Show resolved Hide resolved
@jonatanklosko
Copy link
Member Author

jonatanklosko commented Feb 29, 2024

@hugobarauna we were considering integrating it into Livebook, but this would only be justified if we did accurate stale tracking (e.g. in notebook we do ModA.foo, and ModA.foo implementation calls ModB.bar, and ModB changed, then the notebook cell is stale, but ModA did not change). However, that would require a number of changes to both livebook and elixir and possibly have too much overhead still. So we decided to not do the tracking, but add it for Kino for discoverability (so that people don't need to know about IEx.Helpers.recompile/0) and this way we can have the explicit warning.

Co-authored-by: José Valim <[email protected]>
@jonatanklosko jonatanklosko merged commit 9a0a25c into main Feb 29, 2024
1 check passed
@jonatanklosko jonatanklosko deleted the jk-recompile branch February 29, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants