Enable livemd export for Kino.DataTable #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Sep 21, 2023
| @@ -66,7 +66,11 @@ defmodule Kino.DataTable do | |||
| {data, meta.columns} | |||
| end | |||
|
|
|||
| Kino.Table.new(__MODULE__, {data_rows, data_columns, count, name, sorting_enabled}) | |||
| inspected = inspect(tabular) | |||
There was a problem hiding this comment.
Should we inspect lazily? I guess we have to choose between keeping a reference to the inspect vs to the whole data.
There was a problem hiding this comment.
For small data it doesn't matter, and if it's large data then inspect is less copying (or zero-copy if big enough).
There was a problem hiding this comment.
I was not worried about the copying but the amount of in-memory data we need to keep. I guess at best we can guess for now (and if the data is really large, inspect truncates, so that's a plus).
josevalim
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐈