Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for accessing notebook files - with FSS conversion #319

Merged
merged 10 commits into from
Aug 22, 2023

Conversation

philss
Copy link
Contributor

@philss philss commented Aug 22, 2023

This is a PR containing the changes of #300 and the conversion of Livebook file specs to FSS entries.

@philss
Copy link
Contributor Author

philss commented Aug 22, 2023

cc @jonatanklosko @josevalim

lib/kino/fs.ex Outdated Show resolved Hide resolved
lib/kino/fs.ex Outdated Show resolved Hide resolved
lib/kino/fs.ex Outdated Show resolved Hide resolved
lib/kino/fs.ex Outdated Show resolved Hide resolved
@philss
Copy link
Contributor Author

philss commented Aug 22, 2023

@jonatanklosko thanks for the review! I'm going to make the changes to FSS, and after that I can go back and fix it here.

Copy link
Member

@jonatanklosko jonatanklosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

lib/kino/fs.ex Outdated Show resolved Hide resolved
lib/kino/fs.ex Outdated Show resolved Hide resolved
lib/kino/fs.ex Outdated Show resolved Hide resolved
@jonatanklosko jonatanklosko merged commit e9c96f7 into livebook-dev:main Aug 22, 2023
1 check passed
@philss philss deleted the ps-files-with-fss branch August 22, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants