Skip to content

Commit

Permalink
Applying suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
cristineguadelupe committed Sep 4, 2023
1 parent 12ff20d commit 05d1205
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
1 change: 0 additions & 1 deletion lib/kino/remote_cell.ex
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ defmodule Kino.RemoteCell do
node = unquote(String.to_atom(node))
cookie = unquote(String.to_atom(cookie))
Node.set_cookie(node, cookie)
Node.connect(node)
unquote(call)
end
|> Kino.SmartCell.quoted_to_string()
Expand Down
8 changes: 0 additions & 8 deletions test/kino/remote_cell.exs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ defmodule Kino.RemoteCellTest do
node = :name@node
cookie = :"node-cookie"
Node.set_cookie(node, cookie)
Node.connect(node)
:erpc.call(node, fn -> :ok end)\
"""
end
Expand All @@ -40,7 +39,6 @@ defmodule Kino.RemoteCellTest do
node = :name@node
cookie = :"node-cookie"
Node.set_cookie(node, cookie)
Node.connect(node)
result = :erpc.call(node, fn -> :ok end)\
"""
end
Expand Down Expand Up @@ -79,31 +77,27 @@ defmodule Kino.RemoteCellTest do
node = :name@node
cookie = :"node-cookie"
Node.set_cookie(node, cookie)
Node.connect(node)
:erpc.call(node, fn -> :ok end)\
"""

assert RemoteCell.to_source(code1) == """
node = :name@node
cookie = :"node-cookie"
Node.set_cookie(node, cookie)
Node.connect(node)
:erpc.call(node, fn -> 1 + 1 end)\
"""

assert RemoteCell.to_source(code2) == """
node = :name@node
cookie = :"node-cookie"
Node.set_cookie(node, cookie)
Node.connect(node)
:erpc.call(node, fn -> 1 == 1 end)\
"""

assert RemoteCell.to_source(code3) == """
node = :name@node
cookie = :"node-cookie"
Node.set_cookie(node, cookie)
Node.connect(node)
:erpc.call(node, fn ->
a = 1
Expand All @@ -119,7 +113,6 @@ defmodule Kino.RemoteCellTest do
node = :name@node
cookie = :"node-cookie"
Node.set_cookie(node, cookie)
Node.connect(node)
result = :erpc.call(node, fn -> :ok end)\
"""
end
Expand All @@ -131,7 +124,6 @@ defmodule Kino.RemoteCellTest do
node = :name@node
cookie = :"node-cookie"
Node.set_cookie(node, cookie)
Node.connect(node)
:erpc.call(node, fn -> :ok end)\
"""
end
Expand Down

0 comments on commit 05d1205

Please sign in to comment.