CI: everything in venv in mingw

livMatS · Nov 8, 2024 · 6c2431e · 6c2431e
1 parent 0b04ea7
commit 6c2431e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 22 deletions.
diff --git a/.github/workflows/build-installer-on-windows.yml b/.github/workflows/build-installer-on-windows.yml
@@ -98,6 +98,8 @@ jobs:
     # strategy: only install remaining pythonic dependencies via pip
     - name: Install remaining pythonic dependencies
       run: |
+        source venv/bin/activate
+        
         echo "### python and pip info ###"
         command -v python
         python --version
@@ -111,20 +113,11 @@ jobs:
     - name: Fix setuptools_scm-generated version
       id: fix_version
       run: |
+        source venv/bin/activate
+        
         version=$(SETUPTOOLS_SCM_DEBUG=1 python -m setuptools_scm)  # have version written to file to appear in bundled app as well
         echo "version=$version" >> $GITHUB_OUTPUT
 
-    - name: Create local venv
-      run: |
-        # recursive copy_metadata needed local reinstall of
-        #    $ pip install --ignore-installed six
-        # in minsys2/mingw64, would otherwise fail with
-        #    RuntimeError: No metadata path found for distribution 'six'.
-        # in pyinstaller/hooks/hook-dtoolcore.py
-        python -m venv --system-site-packages venv
-        source venv/bin/activate
-        pip install --ignore-installed six
-
     - name: Log python package info
       run: |
         source venv/bin/activate

diff --git a/.github/workflows/build-on-windows.yml b/.github/workflows/build-on-windows.yml
@@ -98,6 +98,8 @@ jobs:
     # strategy: only install remaining pythonic dependencies via pip
     - name: Install remaining pythonic dependencies
       run: |
+        source venv/bin/activate
+        
         echo "### python and pip info ###"
         command -v python
         python --version
@@ -111,20 +113,11 @@ jobs:
     - name: Fix setuptools_scm-generated version
       id: fix_version
       run: |
+        source venv/bin/activate
+        
         version=$(SETUPTOOLS_SCM_DEBUG=1 python -m setuptools_scm)  # have version written to file to appear in bundled app as well
         echo "version=$version" >> $GITHUB_OUTPUT
 
-    - name: Create local venv
-      run: |
-        # recursive copy_metadata needed local reinstall of
-        #    $ pip install --ignore-installed six
-        # in minsys2/mingw64, would otherwise fail with
-        #    RuntimeError: No metadata path found for distribution 'six'.
-        # in pyinstaller/hooks/hook-dtoolcore.py
-        python -m venv --system-site-packages venv
-        source venv/bin/activate
-        pip install --ignore-installed six
-
     - name: Log python package info
       run: |
         source venv/bin/activate