Change some includes to forward declarations (sogou#57)

* Make thrdpool stronger * Fix some comments * fix grammar * change some include to forward declaration * remove some typedef * move codes Co-authored-by: XieHan <[email protected]>
liujp · Sep 18, 2020 · 65473be · 65473be
1 parent 5d01438
commit 65473be
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 12 deletions.
diff --git a/src/kernel/Communicator.cc b/src/kernel/Communicator.cc
@@ -1686,6 +1686,11 @@ int Communicator::sleep(SleepSession *session)
 	return -1;
 }
 
+int Communicator::is_handler_thread()
+{
+	return thrdpool_in_pool(this->thrdpool);
+}
+
 extern "C" void __thrdpool_schedule(const struct thrdpool_task *, void *,
 									thrdpool_t *);
 

diff --git a/src/kernel/Communicator.h b/src/kernel/Communicator.h
@@ -27,10 +27,7 @@
 #include <pthread.h>
 #include <openssl/ssl.h>
 #include "list.h"
-#include "msgqueue.h"
-#include "thrdpool.h"
 #include "poller.h"
-#include "mpoller.h"
 
 class CommConnection
 {
@@ -263,13 +260,13 @@ class Communicator
 	void io_unbind(IOService *service);
 
 public:
+	int is_handler_thread();
 	int increase_handler_thread();
-	int is_handler_thread() { return thrdpool_in_pool(this->thrdpool); }
 
 private:
-	msgqueue_t *queue;
-	mpoller_t *mpoller;
-	thrdpool_t *thrdpool;
+	struct __mpoller *mpoller;
+	struct __msgqueue *queue;
+	struct __thrdpool *thrdpool;
 	int stop_flag;
 
 private:

diff --git a/src/kernel/Executor.h b/src/kernel/Executor.h
@@ -22,7 +22,6 @@
 #include <stddef.h>
 #include <pthread.h>
 #include "list.h"
-#include "thrdpool.h"
 
 class ExecQueue
 {
@@ -69,7 +68,7 @@ class Executor
 	int request(ExecSession *session, ExecQueue *queue);
 
 private:
-	thrdpool_t *thrdpool;
+	struct __thrdpool *thrdpool;
 
 private:
 	static void executor_thread_routine(void *context);

diff --git a/src/kernel/SleepRequest.h b/src/kernel/SleepRequest.h
@@ -20,6 +20,7 @@
 #define _SLEEPREQUEST_H_
 
 #include "SubTask.h"
+#include "Communicator.h"
 #include "CommScheduler.h"
 
 class SleepRequest : public SubTask, public SleepSession

diff --git a/src/kernel/thrdpool.c b/src/kernel/thrdpool.c
@@ -176,7 +176,7 @@ thrdpool_t *thrdpool_create(size_t nthreads, size_t stacksize)
 	thrdpool_t *pool;
 	int ret;
 
-	pool = (struct __thrdpool *)malloc(sizeof (struct __thrdpool));
+	pool = (thrdpool_t *)malloc(sizeof (thrdpool_t));
 	if (pool)
 	{
 		if (__thrdpool_init_locks(pool) >= 0)

diff --git a/src/kernel/thrdpool.h b/src/kernel/thrdpool.h
@@ -41,8 +41,8 @@ extern "C"
  * A thread task can be scheduled by another task, which is very important,
  * even if the pool is being destroyed. Because thread task is hard to know
  * what's happening to the pool.
- * The thread pool can also be destroyed by a thread task. Although this seems
- * to be strange, it's very logical. Destroying thread pool in thread task
+ * The thread pool can also be destroyed by a thread task. This may sound
+ * strange, but it's very logical. Destroying thread pool in thread task
  * does not end the task thread. It'll run till the end of task.
  */